Remove some ci environment variables

[6543]

remove some environment variables who are either the same value or make no sense to exist in the first place:

CI_STEP_STATUS
CI_STEP_FINISHED
CI_PIPELINE_STATUS
CI_PIPELINE_FINISHED
CI_COMMIT_URL

[anbraten]

Could we remove those things just-in-time when we release 3.0. Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

[qwerty287]

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

[anbraten]

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

I would like to like to do it earliest end of the year. We should provide the community some time between major releases and the breaking changes we would currently apply aren't that critical IMO and the benefits from a users perspective are rather minimal atm.

[zc-devs]

I would add DRONE_* to the list.

[qwerty287]

We keep the drone vars to be compatible to drone plugins.

[6543]

... Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

yes I just want to start adding the changes here and I'll peridically resolve conflicts and update it etc ... as it's easuly forgotten otherwise

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-3846.surge.sh

[codecov]

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.98%. Comparing base (f7d12bf) to head (45475e1).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/frontend/metadata/environment.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
+ Coverage   26.96%   26.98%   +0.02%     
==========================================
  Files         394      394              
  Lines       27418    27395      -23     
==========================================
  Hits         7393     7393              
+ Misses      19325    19302      -23     
  Partials      700      700              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qwerty287]

Canyou remove CI_COMMIT_URL too? It's deprecated

[6543]

@qwerty287 done

[lafriks]

Can't pipeline status be failed if step is executed even when previous steps failed so that you can notify pipeline status?

[6543]

The previous variables are not touched ans are still here ...

[6543]

see https://github.com/woodpecker-ci/woodpecker/pull/3846/files#diff-1e99cd2f64fba341b6c56f31035dafab27d162723b979e023de5858ae1ffaa32L122

@lafriks

[6543]

Can't pipeline status be failed if step is executed even when previous steps failed so that you can notify pipeline status?

well the point is ... a whole pipeline status is completely irrelevant in a step ... enven within the workflow context it is hard to be usefull

and we still have some missmatch because pipeline != workflow but the vars use workflow metadata and prefix it pipeline :/

[6543]

tldr: I dont see any any use in having it in as it is now, if we want something similar it shold be implemented with a new method and with the current terminology in mind e.g. dedicated feature pull

[qwerty287]

untested