-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscription 3.1.56 #198
Emscription 3.1.56 #198
Conversation
Thanks. Running the sample code, I get this error:
Which has a related issue which was recently fixed and closed, so hopefully it's in the next release of emscripten: emscripten-core/emscripten#21104 (comment) |
Please remove the ./dist assets from the PR. Those can be updated and committed later. |
… Disabling -Werror for now, until boost is updated or we vendor boost, or use system installed boost.
56769eb
to
492e4e6
Compare
Done |
👍🏾 is this PR mergeable for now? |
For now I'd rather wait to confirm it works in the next release than changing these values in the current release. |
3.1.57 is out, however there still seem to be some issues. It can build the distributable fine. 3.1.57 will complain about no thread support if run on the master branch. |
I'm getting errors running with emscripten 3.1.57:
Be sure to delete all the build folders before building, and you should see the same error with
|
that is what i get if I run on the master branch. I just ran that rm command and built again on this pr branch and it finished building fine. the new output of |
Excellent, it's building for me too, so I must have done something wrong last time. So two issues I'm seeing:
|
I just pushed a fix for this.
I cannot reproduce this. When I press the Sample Code button, nothing happens. |
@woodser ^ |
Running I think the first step is to ensure this test passes for you before any of these changes (i.e. based on master and with emscripten 3.1.10), so you have a successful baseline. After that test is passing, you should be able to observe the errors by applying the changes in this PR and updating to the latest emscripten. |
Resolved by #258 |
This PR resolves #144