Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double stream reading #17

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

Pol-Valentin
Copy link
Contributor

Hi,

With colleague who is developping a symfony bundle to wrap your lib, we encounter a problem with the input stream reading in php5.5. In the php doc, it is said that we can't seek the input stream under php5.6 (refer to the note paragraph about "php://input"). So we propose to read only once the stream, it's also better for performance. For information we try to use it with zend diactoros, like recommended.

@kocsismate
Copy link
Member

Thanks, really nice catch! I'll release a new patch version soon. By the way, I'll list your project in an integrations section of the readme :)

@kocsismate kocsismate merged commit 5c6b6b2 into woohoolabs:master Mar 25, 2016
@qpautrat
Copy link
Contributor

Thanks @kocsismate !

@kocsismate
Copy link
Member

@Pol-Valentin @qpautrat New version is released, integration is mentioned! Check if something is missing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants