Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-dependencies #120

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Update dev-dependencies #120

merged 5 commits into from
Aug 5, 2024

Conversation

wooorm
Copy link
Owner

@wooorm wooorm commented Aug 1, 2024

Related-to wooorm/mdxjs-rs#49.

/cc @kdy1

@wooorm
Copy link
Owner Author

wooorm commented Aug 1, 2024

The test that currently fails is:

assert_eq!(
to_html_with_options("a { /* } */ } b", &swc)?,
"<p>a b</p>",
"should support an unbalanced closing brace (if JS permits)"
);

@kdy1
Copy link
Collaborator

kdy1 commented Aug 2, 2024

@wooorm I merged/published swc-project/swc#9366 but it still fails.
Are you sure that the CI failure is about SyntaxError::UnterminatedBlockComment?

@wooorm
Copy link
Owner Author

wooorm commented Aug 2, 2024

Quite certain. That’s the only test case that fails.
That’s also what I reproduced as differing in 0.94 (hi being the eof) and 0.99 (hi being 1).
But it’s about the positional info, not the name of the error.
That’s important to MDX: it needs to know when JS fails because of EOF, or because of an earlier error.

@wooorm
Copy link
Owner Author

wooorm commented Aug 2, 2024

Made the “repro” smaller here, see last commit.
When you run:

cargo test --test mdx_expression_text -- --nocapture

You’ll see:

running 1 test
parse_file_as_expr: Err(Error { error: (1..1, Eof) })
error_end: 0..0 0 4
Error: Message { place: Some(Point(1:4 (3))), reason: "Could not parse expression with swc: Unexpected eof", rule_id: "swc", source: "mdx" }
test mdx_expression_text_gnostic ... FAILED

The parse_file_as_expr: bit prints the 1..1 part, that should be like 1..5.
And error_end: 0..0 0 4 should be error_end: 0..4 4 4

@kdy1
Copy link
Collaborator

kdy1 commented Aug 2, 2024

Thank you! I'll fix it later today

@kdy1
Copy link
Collaborator

kdy1 commented Aug 5, 2024

Sorry, I was bit busy. Err(Error { error: (1..1, Eof) }) seems like the cause, and I think it's about SyntaxError::Eof
I linked the SWC repository locally, and I'll fix the span of the error soon.

@kdy1
Copy link
Collaborator

kdy1 commented Aug 5, 2024

Should be fixed by swc-project/swc#9378
I'll update this PR once it's published

kdy1 added a commit to swc-project/swc that referenced this pull request Aug 5, 2024
@kdy1
Copy link
Collaborator

kdy1 commented Aug 5, 2024

I updated swc_core to v0.100.0, and verified that it works

@wooorm wooorm merged commit d0788c9 into main Aug 5, 2024
4 checks passed
@wooorm wooorm deleted the swc branch August 5, 2024 11:45
renovate bot referenced this pull request in oxc-project/oxc Aug 11, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [markdown](https://togithub.com/wooorm/markdown-rs) | dev-dependencies
| patch | `1.0.0-alpha.18` -> `1.0.0-alpha.19` |
| [serde](https://serde.rs)
([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies
| patch | `1.0.204` -> `1.0.206` |
| [tempfile](https://stebalien.com/projects/tempfile-rs/)
([source](https://togithub.com/Stebalien/tempfile)) |
workspace.dependencies | minor | `3.11.0` -> `3.12.0` |

---

### Release Notes

<details>
<summary>wooorm/markdown-rs (markdown)</summary>

###
[`v1.0.0-alpha.19`](https://togithub.com/wooorm/markdown-rs/releases/tag/1.0.0-alpha.19)

[Compare
Source](https://togithub.com/wooorm/markdown-rs/compare/1.0.0-alpha.18...1.0.0-alpha.19)

- [`2c83b0d`](https://togithub.com/wooorm/markdown-rs/commit/2c83b0d)
Fix panic on incomplete closing frontmatter fence
by [@&#8203;nokome](https://togithub.com/nokome) in
[https://github.com/wooorm/markdown-rs/pull/121](https://togithub.com/wooorm/markdown-rs/pull/121)
- [`d0788c9`](https://togithub.com/wooorm/markdown-rs/commit/d0788c9)
Update dev-dependencies
by [@&#8203;wooorm](https://togithub.com/wooorm) in
[https://github.com/wooorm/markdown-rs/pull/120](https://togithub.com/wooorm/markdown-rs/pull/120)

**Full Changelog**:
wooorm/markdown-rs@1.0.0-alpha.18...1.0.0-alpha.19

</details>

<details>
<summary>serde-rs/serde (serde)</summary>

###
[`v1.0.206`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.206)

[Compare
Source](https://togithub.com/serde-rs/serde/compare/v1.0.205...v1.0.206)

- Improve support for `flatten` attribute inside of enums
([#&#8203;2567](https://togithub.com/serde-rs/serde/issues/2567), thanks
[@&#8203;Mingun](https://togithub.com/Mingun))

###
[`v1.0.205`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.205)

[Compare
Source](https://togithub.com/serde-rs/serde/compare/v1.0.204...v1.0.205)

- Use serialize_entry instead of serialize_key + serialize_value when
serialize flattened newtype enum variants
([#&#8203;2785](https://togithub.com/serde-rs/serde/issues/2785), thanks
[@&#8203;Mingun](https://togithub.com/Mingun))
- Avoid triggering a collection_is_never_read lint in the
deserialization of enums containing flattened fields
([#&#8203;2791](https://togithub.com/serde-rs/serde/issues/2791))

</details>

<details>
<summary>Stebalien/tempfile (tempfile)</summary>

###
[`v3.12.0`](https://togithub.com/Stebalien/tempfile/blob/HEAD/CHANGELOG.md#3120)

- Add a `keep(keep: bool)` function to builder that suppresses
delete-on-drop behavior (thanks to
[@&#8203;RalfJung](https://togithub.com/RalfJung)).
-   Update `windows-sys` from 0.52 to 0.59.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10am on monday" in timezone
Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/oxc-project/oxc).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants