Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs#171/README.md 작성 #172

Merged
merged 22 commits into from
Aug 31, 2024
Merged

docs#171/README.md 작성 #172

merged 22 commits into from
Aug 31, 2024

Conversation

bellringstar
Copy link
Collaborator

📄 작업 설명

  • REAME 작성 중입니다.

🚨 관련 이슈

closes #171

🌈 작업 상황

📌 기타

@bellringstar bellringstar added the 문서 Improvements or additions to documentation label Aug 29, 2024
@bellringstar bellringstar requested a review from a team August 29, 2024 09:50
@bellringstar bellringstar self-assigned this Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for twodari canceled.

Name Link
🔨 Latest commit 8937d28
🔍 Latest deploy log https://app.netlify.com/sites/twodari/deploys/66d29455b683dc000802b8b0

Copy link

Code Coverage Report

Overall Project 89.49% 🍏

There is no coverage information present for the Files changed

minnim1010 and others added 21 commits August 30, 2024 09:12
* fix: 티켓, 축제 생성 시 캐시 무효화

* fix: 티켓 재고 생성시 created_at, updated_at 추가

* fix: 에러메시지 구체화

---------

Co-authored-by: bellringstar <[email protected]>
- 티켓 생성 시 레디스에 티켓 정보 넣는 로직 추가
- 10분 내 판매되는 티켓 생성 시 레디스에 티켓 정보 넣는 로직 추가
- 시작 시간을 초단위로 저
Copy link

Risk Level 2 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/festival/repository/FestivalRepository.java

The added conditions in the query improve the filtering of upcoming festivals. Ensure that the logic for handling null values in festivalPublicationStatus is consistent with the rest of the application.


Risk Level 2 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/festival/service/FestivalService.java

The addition of caching annotations is a good optimization. Ensure that the cache eviction logic aligns with the expected behavior of the application, especially when festivals are created or updated.


Risk Level 2 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/global/queue/service/QueueService.java

The addition of scheduled methods for processing the queue is a good improvement. Ensure that the error handling logic is robust to prevent data loss.


🔍✨⚙️


Powered by Code Review GPT

@bellringstar bellringstar merged commit 04fc039 into develop Aug 31, 2024
6 of 7 checks passed
@bellringstar bellringstar deleted the docs#171 branch August 31, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
문서 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: README 문서 작성
3 participants