Feature: 화면 구현에 필요한 API를 추가 구현한다. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 사용자가 명시적으로 좌석 선택 취소시 바로 release할 수 있도록 구현
seminchoi
requested review from
mirageoasis,
hseong3243 and
lass9436
as code owners
hseong3243
reviewed
Aug 22, 2024
| @@ -7,4 +7,6 @@ public interface ReservationService { | |||
| void selectSeat(String memberEmail, SeatSelectionRequest seatSelectionRequest); | |||
|
|
|||
| void reservationTicket(String memberEmail, TicketPaymentRequest ticketPaymentRequest); | |||
|
|
|||
| default void releaseSeat(String memberEmail, SeatSelectionRequest seatSelectionRequest) {} | |||
There was a problem hiding this comment.
디폴트 메서드로 정의하신 이유가 있나요?
| private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(5); | ||
|
|
||
| @Value("${ticketing.reservation.release-delay-seconds}") | ||
| private int reservationReleaseDelay; |
There was a problem hiding this comment.
밖에서 주입하고 final로 선언하는 건 어떤가요?
hseong3243
approved these changes
Aug 22, 2024
lass9436
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
화면 구현에 필요한 API를 추가 구현했습니다.
📝 작업 요약
💡 관련 이슈