Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed request body schema name when using omitted/picked type #546

Merged
merged 4 commits into from
May 25, 2024

Conversation

JadenKim-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When using OmitType or PickType in the swagger.body configuration, the schema name become PickTypeClass or OmitTypeClass.

Issue Number: N/A

What is the new behavior?

It uses schema name which reflect crud method, table name, and source.
ex) 'create' route, 'base' table, request body -> CreateBaseBodyDto

Additionally, improved test code to validate exception message, and remove unnecessary null checks and optional chaining

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr merged commit a103a02 into woowabros:main May 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants