[Hotfix/BE] 로그아웃 시 팔로워 수가 초기화 되는 현상을 수정한다 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: follow, unfollow 로직 MemberUpdate와 분리 * test: 재로그인 시 팔로워 수가 변하지 않는지에 대한 인수테스트 추가
hamcheeseburger
requested review from
Ohzzi,
Youngyoon-1,
yh20studio and
yangdongjue5510
🚧 Analysis ResultsF12-676 Bugs : 0 ✅ |
Youngyoon-1
approved these changes
Sep 26, 2022
| LoginResponse followingResponse = 민초.로그인을_한다(); | ||
| 민초.로그인한_상태로(followingResponse.getToken()).추가정보를_입력한다(memberRequest); | ||
|
|
||
| final LoginResponse followerResponse = 코린.로그인을_한다(); |
Ohzzi
requested changes
Sep 26, 2022
Comment on lines
100
to
105
| public void follow() { | ||
| this.followerCount += 1; | ||
| } | ||
|
|
||
| public void unfollow() { | ||
| if (this.followerCount == 0) { |
There was a problem hiding this comment.
이 member가 follow나 unfollow 동작을 하는 것이 아닌데 follow와 unfollow의 능동형으로 쓰는 것은 어색한 것 같아요!
followerCount에 초점을 두고 increaseFollowerCount, decreaseFollowerCount로 쓰는 것이 어떨까요?
| @@ -640,6 +636,27 @@ class MemberAcceptanceTest extends AcceptanceTest { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void 재로그인_시_팔로워_수가_변하지_않는다() { | |||
🚧 Analysis ResultsF12-676 Bugs : 0 ✅ |
Ohzzi
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용