Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE]: Slack 알림 인터페이스 분리 #473

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

jaejae-yoo
Copy link
Collaborator

@jaejae-yoo jaejae-yoo commented Nov 17, 2022

요약

  • 알림 서비스 인터페이스 분리 및 패키지 정리

세부사항

AS-IS

기존 로직에서는 알림을 보내는 서비스에서 slack 알림 구현체를 직접 의존하고 있었습니다.

    private final SlackUsersClient slackUsersClient;
    private final SlackAlarmSender slackAlarmSender;

TO-BE

추후 gmail smtp 등 다른 서비스로 변경될 수 있기 때문에, 외부 서비스에 의존하는 부분을 추상화에 의존할 수 있도록 인터페이스를 생성했습니다.

@Service
public class AlarmService {

    //...
    private final AlarmUserClient alarmUserClient;
    private final AlarmSender alarmSender;

    //...
} 

@jaejae-yoo jaejae-yoo self-assigned this Nov 17, 2022
@jaejae-yoo jaejae-yoo added 🖥 backend New backend feature 🛠 refactoring Refactor code labels Nov 17, 2022
@woowacourse-teams woowacourse-teams deleted a comment from 2022-moamoa bot Nov 17, 2022
@2022-moamoa
Copy link

2022-moamoa bot commented Nov 17, 2022

Passed

Analysis Details

5 Issues

  • Bug 2 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 3 Code Smells

Coverage and Duplications

  • Coverage No coverage information (67.30% Estimated after merge)
  • Duplications No duplication information (0.30% Estimated after merge)

Project ID: woowacourse-teams_2022-moamoa_AYKvd_z4VbW_bWBvgn13

View in SonarQube

@verus-j verus-j closed this Sep 6, 2023
@verus-j verus-j reopened this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 backend New backend feature 🛠 refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants