[FE] refactor: 검색 탭 삭제 및 순서 수정 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hae-on
reviewed
Sep 7, 2023
| <DropDownIcon variant="arrow" color={theme.colors.black} width={15} height={15} /> | ||
| </TitleLink> | ||
| <Link as={RouterLink} to="/search" style={{ marginLeft: 'auto' }}> |
Leejin-Yang
reviewed
Sep 7, 2023
이렇게 상품, 꿀조합 검색 페이지 나눴습니다. |
Leejin-Yang
approved these changes
Sep 8, 2023
frontend/src/pages/SearchPage.tsx
Outdated
Comment on lines
34
to
35
| const { pathname } = useLocation(); | ||
| const [, , currentPath] = pathname.split('/'); |
There was a problem hiding this comment.
useParams 훅을 사용해보면 어떨까요?
split과 배열에서 뽑는 과정이 없어지겠네요!
frontend/src/router/index.tsx
Outdated
Comment on lines
57
to
61
| path: `${PATH.SEARCH}/products`, | ||
| element: <SearchPage />, | ||
| }, | ||
| { | ||
| path: `${PATH.SEARCH}/recipes`, |
There was a problem hiding this comment.
만약 값을 가져오지 못한다면 다이나믹 세그먼트를 사용해보아요. 그러면 유효하지 않는 페이지는 타입가드해서 Not Found 페이지로 보내면 되겠네요. 이 부분은 페이지 컴포넌트에서 진행하면 되겠습니다 👍
통합 검색 페이지를 추가했습니다. |
Leejin-Yang
approved these changes
Sep 14, 2023
hae-on
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
검색 아이콘을 누르면 해당 페이지로 이동하고, 뒤로 가기를 누르면 이전 페이지로 돌아갑니다.
📢 논의하고 싶은 내용
🎸 기타
x
⏰ 일정