[FE] refactor: 홈 화면 변경 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
reviewed
Sep 14, 2023
Comment on lines
11
to
19
| const menuList = Array.from({ length: MENU_LENGTH }, (_, index) => ({ | ||
| name: MENU_NAME[index], | ||
| image: MENU_IMAGES[index], | ||
| })); | ||
|
|
||
| const storeList = Array.from({ length: STORE_LENGTH }, (_, index) => ({ | ||
| name: STORE_NAMES[index], | ||
| image: STORE_IMAGES[index], | ||
| })); |
| } | ||
|
|
||
| const PBProductList = ({ isHomePage }: PBProductListProps) => { | ||
| const PBProductList = () => { |
xodms0309
approved these changes
Sep 14, 2023
| @@ -38,7 +38,9 @@ export default Carousel; | |||
|
|
|||
| const CarouselContainer = styled.div` | |||
| display: flex; | |||
| width: ${CAROUSEL_WIDTH}px; | |||
| width: 100%; | |||
| return ( | ||
| <CategoryItemContainer variant="transparent"> | ||
| <ImageWrapper> | ||
| <img src={image} width={60} height={60} alt="카테고리" /> |
There was a problem hiding this comment.
alt에 {name}카테고리로 하는건 어떨까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
홈페이지 배너 적용
카테고리 디자인 변경
꿀조합 랭킹 컴포넌트 디자인 변경
📢 논의하고 싶은 내용
중간에 빠진 부분이 있으면 말씀해주세요.
정신 없이 해서 백퍼 있을 거 같음,,,
아직 카테고리 클릭 시 넘어가는 건 구현 안했습니다.
카테고리 로직이 바뀐 거 같아서 그거 머지되면 시작할게요!
근데 어떻게 해야할 지 감이 안오는데 혹시 좋은 아이디어 있으신분은 적어주세욤
🎸 기타
x
⏰ 일정