Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: 코드 포맷 적용, 컨벤션 적용 #632

Merged
merged 12 commits into from
Sep 14, 2023
Merged

Conversation

70825
Copy link
Member

@70825 70825 commented Sep 14, 2023

Issue

✨ 구현한 기능

  • 코드 포맷 전체적으로 돌림
  • Controller, ApiControllerfinal 붙이기 + 나머지 final 빠진 부분 추가
  • KakaoPlatformUserProvider에 환경변수 들어가는 부분 생성자 주입이 아닌 필드로 이동하기
  • Controller → Service로 넘어갈 때, 파라미터로 loginInfo.getId()를 까서 Long으로 보내줌
  • ProductServicegetAllProductsInCategoryageable.getSort().getOrderFor(REVIEW_COUNT) != null대신 Objects.nonNull()를 적용
  • 여러 숫자, 문자, 리스트 상수 처리
  • 사용하지 않는 메서드 삭제
  • application-local.yml에도 s3 설정 추가

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 1

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Unit Test Results

223 tests   223 ✔️  16s ⏱️
112 suites      0 💤
112 files        0

Results for commit d609f1d.

♻️ This comment has been updated with latest results.

@70825 70825 changed the title [BE] 코드 포맷 적용, 컨벤션 적용 [BE] refactor: 코드 포맷 적용, 컨벤션 적용 Sep 14, 2023
@70825 70825 merged commit 5ae7ec0 into develop Sep 14, 2023
3 checks passed
@70825 70825 deleted the feat/issue-627 branch September 14, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 코드 포맷 적용, 컨벤션 적용
1 participant