[FE] refactor: 카테고리 로직 수정 #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Sep 15, 2023
Comment on lines
10
to
29
| const CategoryList = () => { | ||
| const { data: foodCategories } = useCategoryQuery(CATEGORY_TYPE['FOOD']); | ||
| const { data: storeCategories } = useCategoryQuery(CATEGORY_TYPE['STORE']); | ||
|
|
||
| return ( | ||
| <CategoryListContainer> | ||
| <MenuListWrapper> | ||
| {menuList.map((menu, index) => ( | ||
| <Link key={`menuItem-${index}`} as={RouterLink} to={`products/food?category=${index + 1}`}> | ||
| {foodCategories.map((menu) => ( | ||
| <Link key={`menuItem-${menu.id}`} as={RouterLink} to={`products/food?category=${menu.id}`}> | ||
| <CategoryItem name={menu.name} image={menu.image} /> | ||
| </Link> | ||
| ))} | ||
| </MenuListWrapper> | ||
| <StoreListWrapper> | ||
| {storeList.map((menu, index) => ( | ||
| <Link key={`menuItem-${index}`} as={RouterLink} to={`products/store?category=${index + 6}`}> | ||
| <CategoryItem key={`storeItem-${index}`} name={menu.name} image={menu.image} /> | ||
| {storeCategories.map((menu) => ( | ||
| <Link key={`menuItem-${menu.id}`} as={RouterLink} to={`products/store?category=${menu.id}`}> | ||
| <CategoryItem name={menu.name} image={menu.image} /> | ||
| </Link> | ||
| ))} | ||
| </StoreListWrapper> |
There was a problem hiding this comment.
근데 아까는 이게 최선일 것 같았는데 코드 보니까 밖에서 menuVariant 값을 받고 얘는 뿌려주는 역할만 하게끔 하면 어떨까 싶어요
const CategoryList = ({menuVariant}) => {
const { data: categories } = useCategoryQuery(CATEGORY_TYPE[menuVariant]);
return (
<ListWrapper>
{categories.map((menu) => (
<Link key={`menuItem-${menu.id}`} as={RouterLink} to={`products/${menuVariant}?category=${menu.id}`}>
<CategoryItem name={menu.name} image={menu.image} />
</Link>
))}
</ListWrapper>
)이런식으로?? 그리고 밖에서는
<CategoryList menuVariant="FOOD"/>
<CategoryList menuVariant="STORE"/>이렇게 쓰는걸로
Leejin-Yang
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
카테고리 api에 이미지가 추가되어 그에 맞게 로직을 수정하였습니다.
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정