Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat: 홈에서 카테고리 눌렀을 때 context에 저장하는 방식으로 변경 #732

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

xodms0309
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 기존에 쿼리 파라미터를 사용하던 방식을 버튼 클릭했을 때 context에 저장하는 방식으로 변경했습니다.

📢 논의하고 싶은 내용

x

🎸 기타

x

⏰ 일정

  • 추정 시간 :
  • 걸린 시간 : 1시간

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Test Results

2 tests   2 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 7b251d5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완 잘했음 😇

Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타미 진짜 큰 일을 해냈네요!
고마워요 펀잇을 위해 헌신해줘서
파이팅!!

return (
<CategoryItemContainer variant="transparent">
<Button type="button" variant="transparent" customHeight="auto" onClick={() => handleCategoryItemClick(categoryId)}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -41,10 +30,10 @@ const CategoryFoodTab = () => {

return (
<CategoryMenuContainer>
{categories.map((menu) => {
const isSelected = menu.id === currentCategoryId;
{categories.map(({ id, name }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -9,29 +7,20 @@ import { useCategoryActionContext, useCategoryValueContext } from '@/hooks/conte
import { useCategoryFoodQuery } from '@/hooks/queries/product/useCategoryQuery';
import { getTargetCategoryName } from '@/utils/category';

const category = CATEGORY_TYPE.FOOD;
const categoryType = CATEGORY_TYPE.FOOD;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xodms0309 xodms0309 merged commit a3d1be5 into develop Oct 11, 2023
3 checks passed
@xodms0309 xodms0309 deleted the feat/issue-716 branch October 11, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] feat: 홈에서 카테고리 눌렀을 때 카테고리 컨텍스트에 저장
3 participants