Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: ReviewDeleteEventListenerTest 통과하도록 수정 #778

Merged
merged 9 commits into from
Oct 18, 2023
Merged

[BE] fix: ReviewDeleteEventListenerTest 통과하도록 수정 #778

merged 9 commits into from
Oct 18, 2023

Conversation

hanueleee
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 기존에 통과했다 실패했다 하던 ReviewDeleteEventListenerTest 를 통과하도록 고쳤습니다.

📢 논의하고 싶은 내용

  • X

🎸 기타

  • X

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 1

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Test Results

263 tests   263 ✔️  23s ⏱️
132 suites      0 💤
132 files        0 ❌

Results for commit 30457d2.

♻️ This comment has been updated with latest results.

70825
70825 requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve 취소

70825
70825 reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지하기전에 @SuppressWarnings("NonAsciiCharacters") 이거도 추가해주세요~

@hanueleee
Copy link
Collaborator Author

hanueleee commented Oct 16, 2023 •
edited
Loading

실패하던 이유

  • 요약 : 비동기로 동작하기 때문에 테스트 실행 환경에 따라 전 테스트에서 사용된 이벤트가 다음 테스트에서 잡히는 경우 생김
  • 상세 : ""인 이미지를 가지는 event를 사용하는 테스트에서 자꾸 "test3" 이미지(전 테스트에서 사용되는 이미지)를 가지는 event가 잡힘 -> ""여서 작동하지 않아야 하는 delete 메소드가 "test3"을 읽고 작동 -> 실패

해결 : 테스트 이후 event 비워주기 events.clear()

image

원래 이벤트에 대한 테스트를 작성할 때는 마지막에 clear 해주는게 필수라고 합니다 by 제이슨

70825
70825 requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 오잉~
테스트 코드 하나 물어볼거 있어서 코멘트 하나 남겼습니다~

backend/src/test/java/com/funeat/common/EventTest.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/review/application/ReviewDeleteEventListener.java Show resolved Hide resolved
wugawuga
wugawuga approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 이벤트 테스트,,,,,👍

backend/src/main/java/com/funeat/review/application/ReviewDeleteEventListener.java Show resolved Hide resolved
@hanueleee
Copy link
Collaborator Author

hasText는 자바17에서 제공되는 기능이라 그대로 유지하는것으로 결정했습니다~~
(펀잇은 자바11 사용)

Go-Jaecheol
Go-Jaecheol approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 수정 좋아용 👍

@hanueleee hanueleee merged commit 16de45c into develop Oct 18, 2023
3 checks passed
@hanueleee hanueleee deleted the feat/issue-777 branch October 18, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

@70825 70825 70825 approved these changes

@wugawuga wugawuga wugawuga approved these changes

Assignees

@hanueleee hanueleee

Labels
🔒 BE 🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] fix: 실패하는 이벤트 테스트 수정
4 participants
@hanueleee @Go-Jaecheol @70825 @wugawuga