Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] router 리팩터링 #806

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[FE] router 리팩터링 #806

merged 2 commits into from
Oct 19, 2023

Conversation

xodms0309
Copy link
Collaborator

@xodms0309 xodms0309 commented Oct 19, 2023

Issue

✨ 구현한 기능

  • RecipeDetail 페이지를 AuthLayout 아래로 이동
  • 각 router layout에 주석 작성

📢 논의하고 싶은 내용

x

🎸 기타

x

⏰ 일정

  • 추정 시간 : 10분
  • 걸린 시간 : 10분

Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Comment on lines +57 to +78
/** 로그인이 안되었다면 로그인 페이지로 리다이렉트하면서 헤더만 있는 레이아웃 */
{
path: '/',
element: (
<AuthLayout>
<App layout="headerOnly" />
</AuthLayout>
),
errorElement: <Navigate to={PATH.LOGIN} replace />,
children: [
{
path: `${PATH.RECIPE}/:recipeId`,
async lazy() {
const { RecipeDetailPage } = await import(
/* webpackChunkName: "RecipeDetailPage" */ '@/pages/RecipeDetailPage'
);
return { Component: RecipeDetailPage };
},
},
],
},
/** 헤더와 네비게이션 바가 있는 기본 레이아웃 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Test Results

2 tests   2 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit b702a49.

Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깜빡~

@xodms0309 xodms0309 merged commit 9e928b3 into develop Oct 19, 2023
3 checks passed
@xodms0309 xodms0309 deleted the feat/issue-804 branch October 19, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] router 리팩터링
3 participants