-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
모달에서 ScrollSnapContainer의 스와이프가 동작하는 오류 수정 #517
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8dbece
Merge pull request #497 from woowacourse-teams/refactor/485-register-…
green-kong 30ffc8f
Merge pull request #509 from woowacourse-teams/refactor/481-generaliz…
solo5star 3bf205b
Merge branch 'main' into feat/475-organize-priority-of-image-fetch
solo5star b124eb8
Merge pull request #511 from woowacourse-teams/feat/475-organize-prio…
solo5star 3d7b5ba
feat: ScrollSnap을 방지하는 `useScrollSnapGuard` 훅 구현
solo5star 261a280
fix: useScrollSnapGuard 를 적용하여 모달에서 ScrollSnapContainer의 스크롤 방지
solo5star File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import type { EventHandler, SyntheticEvent } from 'react'; | ||
import { useCallback, useMemo } from 'react'; | ||
|
||
/** | ||
* ScrollSnapContainer의 하위 요소에서 열린 모달에서 스크롤 혹은 스와이프를 할 시 | ||
* ScrollSnapContainer에 전파되어 스와이프가 동작하는 문제가 발생합니다. | ||
* ScrollSnapContainer의 스와이프가 동작하지 않도록 갖가지 이벤트의 propagation을 막아주는 훅입니다. | ||
*/ | ||
const useScrollSnapGuard = () => { | ||
const preventPropagation: EventHandler<SyntheticEvent> = useCallback((event) => { | ||
event.stopPropagation(); | ||
}, []); | ||
|
||
const handlers = useMemo( | ||
() => ({ | ||
onTouchStart: preventPropagation, | ||
onTouchMove: preventPropagation, | ||
onTouchEnd: preventPropagation, | ||
onMouseDown: preventPropagation, | ||
onMouseMove: preventPropagation, | ||
onMouseUp: preventPropagation, | ||
onMouseLeave: preventPropagation, | ||
onWheel: preventPropagation, | ||
}), | ||
[preventPropagation], | ||
); | ||
|
||
return handlers; | ||
}; | ||
|
||
export default useScrollSnapGuard; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋ
event.stopPropagation()
으로 모달에서 스와이프가 동작하는 오류를 수정하셨군여!좋습니당