Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

크롬 extension cors 설정 추가 #616

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

kyum-q
Copy link
Contributor

@kyum-q kyum-q commented Sep 6, 2024

⚡️ 관련 이슈

#615

📍주요 변경 사항

크롬 extension cors 허용을 위해 "chrome-extension://bmlonhfgleihfabinjbhgefojkfpmlaf" 해당 접근도 허용허도록 변경

🎸기타

@kyum-q kyum-q added bug 개발자가 의도하지 않은 상황 BE 백엔드 labels Sep 6, 2024
@kyum-q kyum-q added this to the 1.1.1 배포 milestone Sep 6, 2024
@kyum-q kyum-q self-assigned this Sep 6, 2024
@kyum-q kyum-q changed the base branch from main to dev/be September 6, 2024 04:10
Comment on lines 13 to 19
.allowCredentials(true)
.allowedOriginPatterns("https://*.code-zap.com")
.allowedOrigins("https://code-zap.com")
.allowedOrigins("chrome-extension://bmlonhfgleihfabinjbhgefojkfpmlaf")
.allowedMethods("*")
.exposedHeaders("*");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것도 가능한가욥 꺄르륵

Suggested change
.allowCredentials(true)
.allowedOriginPatterns("https://*.code-zap.com")
.allowedOrigins("https://code-zap.com")
.allowedOrigins("chrome-extension://bmlonhfgleihfabinjbhgefojkfpmlaf")
.allowedMethods("*")
.exposedHeaders("*");
}
.allowCredentials(true)
.allowedOriginPatterns("https://*.code-zap.com")
.allowedOrigins("https://code-zap.com", "chrome-extension://bmlonhfgleihfabinjbhgefojkfpmlaf")
.allowedMethods("*")
.exposedHeaders("*");
}

Copy link
Contributor

@Jaymyong66 Jaymyong66 Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoxy 브랜치명도 bug 아니고 fix..? 꺄르륵

@jminkkk jminkkk merged commit ebd9ccd into dev/be Sep 6, 2024
9 checks passed
@jminkkk jminkkk deleted the bug/615-extension-CORS branch September 6, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 bug 개발자가 의도하지 않은 상황
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

6 participants