썸네일 서비스 테스트코드 작성 #662
Merged
썸네일 서비스 테스트코드 작성 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyum-q
reviewed
Sep 18, 2024
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
jminkkk
reviewed
Sep 19, 2024
Comment on lines
+57
to
+59
| var member = memberRepository.save(MemberFixture.getFirstMember()); | ||
| var category = categoryRepository.save(CategoryFixture.getFirstCategory()); | ||
| var template = templateRepository.save(TemplateFixture.get(member, category)); |
There was a problem hiding this comment.
중복되는 코드 private 메서드로 추출해볼까요?
There was a problem hiding this comment.
이거는 일부러 분리하지 않았는데요, 전에 켬미와 얘기했던 @beforeeach를 사용하지 않는 이유에 동의했기 때문입니다!
물론 private 메서드로 분리하는 것은 @beforeeach보다는 덜하겠지만 그래도 어떤 객체들이 저장되어 있는지 테스트 코드 안에서 바로 확인할 수 있는게 보다 명확하게 알 수 있지 않을까 싶어서 분리하지 않았습니다.
또한 코드의 길이가 길지 않아 테스트 코드의 가독성을 해친다는 느낌도 없는 것 같은데 몰리의 의견은 어떤가요?
There was a problem hiding this comment.
@BeforeEach를 사용하지 않았던 이유가 특정 테스트만 조회할 때 @BeforeEach 보지 못하고 이해하지 못할까봐로 저는 알고 있는데 같은 이유가 맞나요?
그렇다면, private 메서드는 @BeforeEach과 다르게 메서드 안에서 "선언"을 해주기 때문에 보는 사람이 충분히 메서드 내에서 파악할 수 있을 것이라고 생각해요.
또 private 메서드를 사용하더라도 이름을 명확하게 설정해주면 메서드를 정말 확인하지 않아도 파악할 수 있을 것 (레벨 1 네오 강의 의견처럼요) 이라고도 생각해요.
zangsu
reviewed
Sep 19, 2024
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Show resolved
Hide resolved
zeus6768
requested changes
Sep 19, 2024
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/codezap/template/service/ThumbnailServiceTest.java
Outdated
Show resolved
Hide resolved
zangsu
approved these changes
Sep 20, 2024
jminkkk
approved these changes
Sep 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #645
📍주요 변경 사항
ThumbnailSerivce 테스트 작성
🎸기타
리팩토링