Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

목록 조회 페이지 기본 값을 0으로 변경 #691

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Sep 25, 2024

⚡️ 관련 이슈

close #690

📍주요 변경 사항

spring:
  data.web.pageable.one-indexed-parameters: true

사용 시 기본 Controller 단에 도착하기 전에 위 설정이 적용되어 page 값이 1 적게 옵니다.
내부 레포지토리 로직에서는 여전히 0-based 인덱스를 사용합니다.

따라서 Controller에서 기본 값을 1이 아닌 0으로 재설정해줍니다.

@jminkkk jminkkk added bug 개발자가 의도하지 않은 상황 BE 백엔드 labels Sep 25, 2024
@jminkkk jminkkk added this to the 5차 스프린트🍗 milestone Sep 25, 2024
@jminkkk jminkkk self-assigned this Sep 25, 2024
@jminkkk jminkkk changed the base branch from main to dev/be September 25, 2024 07:25
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요한 버그를 찾았네요 고생했어요!!

Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kyum-q kyum-q self-assigned this Sep 25, 2024
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰짱몰짱!!

@HoeSeong123 HoeSeong123 merged commit 254555b into dev/be Sep 26, 2024
7 checks passed
@HoeSeong123 HoeSeong123 deleted the fix/690-pagenation-default branch September 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 bug 개발자가 의도하지 않은 상황
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

[BUG] 페이지네이션 기본 값 재설정
5 participants