Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSearchResults 생성 및 적용 #714

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

Hain-tain
Copy link
Contributor

⚡️ 관련 이슈

📍주요 변경 사항

1. 구경가기 페이지에서 검색 결과 없을경우 NoSearchResults 보여주도록 수정

@Hain-tain Hain-tain added feature 기능 추가 FE 프론트엔드 labels Sep 26, 2024
@Hain-tain Hain-tain added this to the 5차 스프린트🍗 milestone Sep 26, 2024
@Hain-tain Hain-tain self-assigned this Sep 26, 2024
@Hain-tain Hain-tain added the zap 리뷰 우선순위가 높은 사항 label Sep 26, 2024
vi-wolhwa
vi-wolhwa previously approved these changes Sep 27, 2024
@@ -3,7 +3,8 @@ import { Link } from 'react-router-dom';

import { DEFAULT_SORTING_OPTION, SORTING_OPTIONS } from '@/api';
import { ArrowUpIcon, SearchIcon, ZapzapLogo } from '@/assets/images';
import { Dropdown, Flex, Heading, Input, PagingButtons, TemplateCard } from '@/components';
import { Dropdown, Flex, Heading, Input, NoSearchResults, PagingButtons, TemplateCard } from '@/components';
import { LoadingBallContainer } from '@/components/LoadingBall/LoadingBall.style';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 수정 필요할거 같아요!

@Jaymyong66 Jaymyong66 merged commit 842bbdd into dev/fe Sep 27, 2024
3 checks passed
@Jaymyong66 Jaymyong66 deleted the feat/707-explore-search-and-sort-by-likes branch September 27, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 feature 기능 추가 zap 리뷰 우선순위가 높은 사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

3 participants