Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

태그 및 카테고리 생성 시 글자수 검증 #728

Merged
merged 4 commits into from
Oct 7, 2024
Merged

태그 및 카테고리 생성 시 글자수 검증 #728

merged 4 commits into from
Oct 7, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Oct 3, 2024 •
edited
Loading

⚡️ 관련 이슈

close #512

📍주요 변경 사항

  1. 태그 및 카테고리 생성 시 글자수 검증
  2. 기존 @ByteLength에 List 에 대해 글자 수 검증을 하는 GroupedByteLengthValidator 객체를 추가하였습니다.
  • @ByteLength 사용 시 타입에 맞는 validator 클래스가 선택되어 검증합니다.

@jminkkk jminkkk self-assigned this Oct 3, 2024
@jminkkk jminkkk added feature 기능 추가 BE 백엔드 labels Oct 3, 2024
@jminkkk jminkkk added this to the 6차 스프린트 🦴 milestone Oct 3, 2024
zangsu
zangsu reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리~~~ 주말인데도 열심히 작업해 주시는군요 👍
가벼운 코멘트 하나 남겨두었으니 확인해주세요~~

backend/src/main/java/codezap/global/validation/GroupedByteLengthValidator.java Outdated Show resolved Hide resolved
kyum-q
kyum-q previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 굿 !

zeus6768
zeus6768 previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 멋져요 👍

@jminkkk jminkkk dismissed stale reviews from zeus6768 and kyum-q via 50f2e21 October 5, 2024 04:51
zangsu
zangsu approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리짱~~

HoeSeong123
HoeSeong123 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 멋져요 몰리 멋몰!!!!👍

@kyum-q kyum-q merged commit 37e2665 into dev/be Oct 7, 2024
6 checks passed
@kyum-q kyum-q deleted the feat/512-category-tag-length-validate branch October 7, 2024 06:59
@jminkkk jminkkk linked an issue Oct 7, 2024 that may be closed by this pull request
[REFACTOR] 태그, 카테고리 정책 반영 #512
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zangsu zangsu zangsu approved these changes

@zeus6768 zeus6768 zeus6768 approved these changes

@kyum-q kyum-q kyum-q approved these changes

@HoeSeong123 HoeSeong123 HoeSeong123 approved these changes

Assignees

@jminkkk jminkkk

Labels
BE 백엔드 feature 기능 추가
Projects
2024-code-zap
Status: Weekend Done
Milestone
6차 스프린트 🦴
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 태그, 카테고리 정책 반영
5 participants
@jminkkk @zangsu @zeus6768 @kyum-q @HoeSeong123