Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthenticationPrinciple 어노테이션에 required 속성 추가 #747
AuthenticationPrinciple 어노테이션에 required 속성 추가 #747
Changes from 6 commits
51b6db5
8312373
82d27a3
da864d9
c566ce6
55ca8c1
a250725
ce98d64
984ff46
41dae36
f7fee28
02d083a
287691c
3b12062
035a5e5
225430c
c112462
506f9dd
b49e6d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기선 삼항연산자를 사용하는게 더 보기 좋을 것 같은데, 짱수 생각은 다를 수 있으니 자유롭게 반영해주세요.
삼항연산자는 컨벤션에 반하는 문법이지만 컨벤션이라는 것도 코드를 더 잘 관리하기 위해 존재하는 것이라, 이렇게 코드가 긴 경우에는 예외적으로 사용해도 좋을 것 같아 제안해요~
TO-BE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오! 저는 꽤나 만족스러운 결과로 보이는데요!!!
다만 이 부분은 컨벤션과 관련된 부분이라서 다른 크루들의 의견도 묻고 싶어요. (괜히 수정했다가 롤백 하게 될까봐... 😅 )
@jminkkk @kyum-q @HoeSeong123 다들 어떻게 생각하시나용??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 좋다고 생각해요. 삼항연산자를 안 쓰는 이유는 코드의 가독성이 떨어지기 때문이라고 생각하는데, 이 경우는 오히려 올라가지 않았나...라고 생각합니닷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 동의합니답~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모두 동의한다면 반박할 이유가 없어용~!
! 굿 쟞!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 위와 같은 내용입니다~