같은 경로로 이동시 히스토리 쌓이지 않도록 변경 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaymyong66
reviewed
Oct 7, 2024
Comment on lines
+7
to
+12
| return (to: To | number, options?: NavigateOptions) => { | ||
| if (typeof to === 'number') { | ||
| navigate(to); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
단순 궁금증) To 타입의 객체 말고 number로 오는 케이스가 있나요?! useNavigate 의 NavigateFunction타입을 보니까 정확히 To 타입만 인 것 같아서요!
혹은 해당 타입의 delta에 대응을 해준 건가요?
export interface NavigateFunction {
(to: To, options?: NavigateOptions): void;
(delta: number): void;
}There was a problem hiding this comment.
뒤로가기 navigate(-1) 를 대응해주기 위해서 number 를 추가하였습니다!
| @@ -11,7 +10,7 @@ interface Props { | |||
| } | |||
|
|
|||
| const NonmemberAlerter = ({ isOpen, content, toggleModal }: Props) => { | |||
| const navigate = useNavigate(); | |||
| const navigate = useCustomNavigate(); | |||
There was a problem hiding this comment.
이제 useNavigate를 사용해야할 때는 useCustomNavigate로 쓰면 될까요?!
There was a problem hiding this comment.
사실 반복적으로 접근할 수 있는 곳이 많지 않기때문에 useNavigate 를 써도 무방한 상황이 존재하긴 합니다. 그러나 일관성을 위해 useCustomNavigate를 쓰면 좋을 것 같다고 생각하여 모든 로직에서 변경하였습니다.
추후 navigate가 필요한 부분이 있다면 useCustomNavigate를 써도 좋을 것 같아요!ㅎㅎ
| @@ -0,0 +1,24 @@ | |||
| import { useNavigate, useLocation, NavigateOptions, To } from 'react-router-dom'; | |||
|
|
|||
| export const useCustomNavigate = () => { | |||
There was a problem hiding this comment.
요런 훅을 만들 때는 JSDoc이나 일반 주석으로 설명을 적어놓으면 해당 custom의 의도를 잊지 않을 것 같아요~!
There was a problem hiding this comment.
좋은 생각이네요! 추가해두도록 하겠습니다!
vi-wolhwa
previously approved these changes
Oct 7, 2024
vi-wolhwa
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
📍주요 변경 사항
1.
useCustomNavigate를 생성하여 같은 경로로 이동시 히스토리가 쌓이지 않도록 변경하였습니다.