Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

로그백 롤링 파일 정책 변경 #764

Merged
merged 4 commits into from
Oct 12, 2024
Merged

로그백 롤링 파일 정책 변경 #764

merged 4 commits into from
Oct 12, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Oct 9, 2024

⚡️ 관련 이슈

close #763

📍주요 변경 사항

  1. 로그백의 설정을 SizeAndTimeBased -> TimeBased로 변경합니다.

🎸기타

  1. 이슈에 변경 이유 작성해놓았으니 참고 부탁드립니다~

@jminkkk jminkkk added refactor 요구사항이 바뀌지 않은 변경사항 BE 백엔드 labels Oct 9, 2024
@jminkkk jminkkk added this to the 6차 스프린트 🦴 milestone Oct 9, 2024
@jminkkk jminkkk self-assigned this Oct 9, 2024
zeus6768
zeus6768 requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요 몰리~!

몰리의 이슈를 저도 금방 공식문서를 찾아봤는데, TimeBasedRollingPolicy를 사용하면서도 용량으로 rolling할 수 있는 것 같아요.

해당 내용 이슈에 코멘트 남겼는데, 어떻게 생각하는지 궁금해요~!

zangsu
zangsu previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 상황에 빠른 대처, 몰리 킹왕캡짱굳갓잽

@jminkkk
Copy link
Contributor Author

jminkkk commented Oct 9, 2024

멋져요 몰리~!

몰리의 이슈를 저도 금방 공식문서를 찾아봤는데, TimeBasedRollingPolicy를 사용하면서도 용량으로 rolling할 수 있는 것 같아요.

해당 내용 이슈에 코멘트 남겼는데, 어떻게 생각하는지 궁금해요~!

굿! 반영했습니다~!!

@jminkkk jminkkk requested a review from zeus6768 October 9, 2024 12:45
HoeSeong123
HoeSeong123 previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런건 또 언제 찾아봤대!!
멋져요 몰리👍

kyum-q
kyum-q previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 체고에요 ~ 문제를 파악하고 해결하는 멋진 몰리네요 ~

zeus6768
zeus6768 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zeus6768
zeus6768 requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TotalSizeCap을 늘려야 할 것 같아요~

짱수의 이슈 코멘트를 보고 찾아봤는데, TotalSizeCap은 모든 날짜의 모든 로그의 용량의 총합을 의미한대요.

1GB가 좋을 것 같아요~!

@jminkkk jminkkk dismissed stale reviews from kyum-q and HoeSeong123 via c4a39e1 October 10, 2024 04:11
@jminkkk
Copy link
Contributor Author

jminkkk commented Oct 10, 2024

대면 회의에서 논의했던 것처럼 1GB는 부족할 수도 있을 것 같아, 10GB로 변경완료하였습니다~!

HoeSeong123
HoeSeong123 previously approved these changes Oct 10, 2024
View reviewed changes
zeus6768
zeus6768 requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏

로그 대상이 info, warn, error 세 개네요.

각각에 대하여 10기가씩하면 총합이 30기가인데, EC2 인스턴스의 용량이 28기가이므로 낮춰야겠습니다 ㅠ.ㅠ

5GB로 해볼까요? ㅎㅎ...ㅋㅋ!

kyum-q
kyum-q previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 체고~

@jminkkk jminkkk dismissed stale reviews from kyum-q and HoeSeong123 via 1fe1c17 October 11, 2024 04:48
zangsu
zangsu approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지민크크크 수고했습니다~!!

@zangsu zangsu merged commit 3be8941 into dev/be Oct 12, 2024
5 checks passed
@zangsu zangsu deleted the refactor/763-reconfig-file-rolling-policy branch October 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zangsu zangsu zangsu approved these changes

@zeus6768 zeus6768 zeus6768 approved these changes

@kyum-q kyum-q kyum-q approved these changes

@HoeSeong123 HoeSeong123 HoeSeong123 approved these changes

Assignees

@jminkkk jminkkk

Labels
BE 백엔드 refactor 요구사항이 바뀌지 않은 변경사항
Projects
2024-code-zap
Status: Weekend Done
Milestone
6차 스프린트 🦴
Development

Successfully merging this pull request may close these issues.
5 participants
@jminkkk @zangsu @zeus6768 @kyum-q @HoeSeong123