Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 에러코드 detail 정보 없는 경우 수정 및 스웨거 수정 #774

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[FIX] 에러코드 detail 정보 없는 경우 수정 및 스웨거 수정 #774

merged 1 commit into from
Oct 11, 2024

Conversation

kyum-q
Copy link
Contributor

@kyum-q kyum-q commented Oct 11, 2024 •
edited
Loading

⚡️ 관련 이슈

#521

📍주요 변경 사항

문제

  • 스프링에서 반환하는 response에는 detail 정보가 없는 문제 있었음
  • 스웨거에서 직렬화 하는 코드에서 문제 발생 -> problemDetail에 새로운 값으로 LocalDateTime이 추가되는데 이는 직렬화가 안됨

해결

  • 커스텀하기 전 전달 객체가 이미 ProblemDetail이어서 전달 객체에 커스텀 properties만 추가
  • problemDetail에 LocalDateTime을 toString()해서 문자열로 변환

🎸기타

@kyum-q kyum-q added bug 개발자가 의도하지 않은 상황 zap 리뷰 우선순위가 높은 사항 BE 백엔드 labels Oct 11, 2024
@kyum-q kyum-q added this to the 6차 스프린트 🦴 milestone Oct 11, 2024
@kyum-q kyum-q self-assigned this Oct 11, 2024
zeus6768
zeus6768 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zangsu
zangsu approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HoeSeong123 HoeSeong123 merged commit 1ccb9ee into dev/be Oct 11, 2024
6 checks passed
@HoeSeong123 HoeSeong123 deleted the fix/521-error-response branch October 11, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zangsu zangsu zangsu approved these changes

@zeus6768 zeus6768 zeus6768 approved these changes

@jminkkk jminkkk jminkkk approved these changes

@HoeSeong123 HoeSeong123 HoeSeong123 approved these changes

Assignees

@kyum-q kyum-q

Labels
BE 백엔드 bug 개발자가 의도하지 않은 상황 zap 리뷰 우선순위가 높은 사항
Projects
2024-code-zap
Status: Weekend Done
Milestone
6차 스프린트 🦴
Development

Successfully merging this pull request may close these issues.
5 participants
@kyum-q @zangsu @zeus6768 @jminkkk @HoeSeong123