Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagControllerTest 작성 #775

Merged
merged 2 commits into from
Oct 15, 2024
Merged

TagControllerTest 작성 #775

merged 2 commits into from
Oct 15, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Oct 11, 2024

⚡️ 관련 이슈

close #767

📍주요 변경 사항

  1. 태그 컨트롤러 테스트를 추가했습니다.
  • GET /tags API

@jminkkk jminkkk added refactor 요구사항이 바뀌지 않은 변경사항 BE 백엔드 labels Oct 11, 2024
@jminkkk jminkkk added this to the 6차 스프린트 🦴 milestone Oct 11, 2024
@jminkkk jminkkk self-assigned this Oct 11, 2024
@jminkkk jminkkk changed the title Tag 컨트롤러 테스트 추가 TagControllerTest 작성 Oct 12, 2024
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 멋져 몰리
역멋몰👍

Comment on lines +35 to +36
mvc.perform(get("/tags")
.param("memberId", "1"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mvc.perform(get("/tags")
.param("memberId", "1"))
mvc.perform(get("/tags").param("memberId", "1"))

이거 붙이는거 살짝 별론가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 요청들이랑 일관성이 있어야 할 것 같은데 그러면 post도 붙일까요?
저는 둘 다 상관없어서 괜찮은 거 말해주심 반영할게욥~

            mvc.perform(post("/templates").contentType(MediaType.APPLICATION_JSON)

Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 굿입니다 !! 체거체거 👍🏻

Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 최고 🚀

Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 잡을 곳이 없음이네요.

@kyum-q kyum-q merged commit d45adc3 into dev/be Oct 15, 2024
6 checks passed
@kyum-q kyum-q deleted the refactor/767-tag-controller-test branch October 15, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 refactor 요구사항이 바뀌지 않은 변경사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

5 participants