CategoryControllerTest 에러코드 확인 로직 추가 및 개선 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyum-q
requested review from
HoeSeong123,
jminkkk,
zeus6768 and
zangsu
and removed request for
HoeSeong123 and
jminkkk
HoeSeong123
previously approved these changes
Oct 16, 2024
Comment on lines
+95
to
+96
| .andExpect(jsonPath("$.detail").value("카테고리 이름은 최대 15자까지 입력 가능합니다.")) | ||
| .andExpect(jsonPath("$.errorCode").value(1101)); |
zeus6768
previously approved these changes
Oct 16, 2024
jminkkk
reviewed
Oct 16, 2024
| } | ||
|
|
||
| @Test | ||
| @DisplayName("카테고리 수정 실패: 중복된 이름의 카테고리 존재") | ||
| void updateCategoryFailWithDuplicatedName() throws Exception { | ||
| // given |
There was a problem hiding this comment.
이 테스트는 서비스단의 책임인 것 같다고 느껴지는데 켬미 생각은 어떤가요?0?
There was a problem hiding this comment.
그러네요 ~!
해당 메서드와 그 외 서비스 단 테스트인 것들은 PR과 같이 제거했습니다. ~
| verify(categoryService, times(1)) | ||
| .deleteById(MemberFixture.memberFixture(), categoryId); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("카테고리 삭제 실패: 권한 없음") | ||
| void deleteCategoryFailWithUnauthorized() throws Exception { | ||
| // given |
There was a problem hiding this comment.
권한 없음이 403으로 느껴져서 로그인 되지 않은 경우 또는 회원이 아닌 경우로 변경하면 어떤가요~?
HoeSeong123
approved these changes
Oct 18, 2024
zeus6768
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
#767
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
10/17 10:00