Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete 메서드명 명확하게 변경 #792

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

kyum-q
Copy link
Contributor

@kyum-q kyum-q commented Oct 15, 2024

⚡️ 관련 이슈

#645

📍주요 변경 사항

주요 변경 사항에 대해 작성해주세요.

관련 PR 코멘트

  • 메서드명 수정

    • deleteByMemberAndIds(Member member, List ids) -> deleteAllByMemberAndTemplateIds(Member member, List templateIds)
    • 서비스 단에 모든 deleteByTemplateIds(List templateIds) -> deleteAllByTemplateIds(List templateIds)
    • 레포지토리 단에 모든 deleteByTemplateIds(List ids) -> deleteAllByTemplateIds(List templateIds)
  • @param 추가

    • 코드 일관성을 위해 모든 JPQL에 @param을 추가했습니다 !

🎸기타

고려해야 하는 내용을 작성해 주세요.

가끔 설정이 안되있는 경우 자동으로 param 설정이 안될 때가 있음을 방지하기 위해, 앞으로 JPQL 사용 시 @param을 필수로 하면 좋을 것 같아요.

🍗 PR 첫 리뷰 마감 기한

10/17 10:00 (오전)

@kyum-q kyum-q added refactor 요구사항이 바뀌지 않은 변경사항 BE 백엔드 labels Oct 15, 2024
@kyum-q kyum-q added this to the 6차 스프린트 🦴 milestone Oct 15, 2024
@kyum-q kyum-q self-assigned this Oct 15, 2024
@kyum-q kyum-q changed the base branch from main to dev/be October 15, 2024 07:59
@kyum-q kyum-q changed the title Refactor/645 change delete method name delete 메서드명 명확하게 변경 Oct 15, 2024
Copy link
Contributor

@jminkkk jminkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

켬미 굿~!

Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 정리 너무 좋아요!! 고생했습니다 🔥

Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘훌(너무 훌륭하다는 뜻)

@zangsu zangsu merged commit 77a05f4 into dev/be Oct 17, 2024
7 checks passed
@zangsu zangsu deleted the refactor/645-change-delete-method-name branch October 17, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 refactor 요구사항이 바뀌지 않은 변경사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

5 participants