Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSourceConfig를 모든 환경에 적용되도록 변경 #799

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

kyum-q
Copy link
Contributor

@kyum-q kyum-q commented Oct 16, 2024

⚡️ 관련 이슈

#744

📍주요 변경 사항

주요 변경 사항에 대해 작성해주세요.

  • 모든 환경에서 prod 설정을 따르도록 변경

🎸기타

image

로컬도 동일하게 설정하기 위해 해당 설정을 해주세요

test/resources 디렉토리에 환경변수를 모두 대입한 application.yml 파일을 만들어두면 테스트가 편리합니다.

testContainer를 고려해야 할 것 같아요...

🍗 PR 첫 리뷰 마감 기한

10/16 18:00

@kyum-q kyum-q added refactor 요구사항이 바뀌지 않은 변경사항 zap 리뷰 우선순위가 높은 사항 BE 백엔드 labels Oct 16, 2024
@kyum-q kyum-q added this to the 6차 스프린트 🦴 milestone Oct 16, 2024
@kyum-q kyum-q changed the base branch from main to dev/be October 16, 2024 07:24
zeus6768
zeus6768 previously approved these changes Oct 16, 2024
@zeus6768 zeus6768 self-requested a review October 16, 2024 11:30
@zeus6768 zeus6768 merged commit 7535f77 into dev/be Oct 17, 2024
5 checks passed
@zeus6768 zeus6768 deleted the refactor/744-dev-db-setting branch October 17, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 refactor 요구사항이 바뀌지 않은 변경사항 zap 리뷰 우선순위가 높은 사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

5 participants