상세 조회에서 다른 사람의 비공개 템플릿 확인 시 예외 처리 #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeus6768
requested changes
Oct 22, 2024
Comment on lines
84
to
98
| public void validateAuthorization(Member member) { | ||
| if (!getMember().equals(member)) { | ||
| if (!matchMember(member)) { | ||
| throw new CodeZapException(ErrorCode.FORBIDDEN_ACCESS, "해당 템플릿에 대한 권한이 없습니다."); | ||
| } | ||
| } | ||
|
|
||
| public boolean matchMember(Member member) { | ||
| return getMember().equals(member); | ||
| } | ||
|
|
||
| public void ensureNotPrivateTemplate() { | ||
| if (visibility == Visibility.PRIVATE) { | ||
| throw new CodeZapException(ErrorCode.FORBIDDEN_ACCESS, "해당 템플릿은 비공개 템플릿입니다."); | ||
| } | ||
| } |
There was a problem hiding this comment.
ErrorCode는 뷰 로직 같은데, 도메인에서 의존하면 안 되지 않을까요?
Template에서는 예외를 직접 발생시키기보다 boolean을 반환하면 더 좋다고 생각하는데, 켬미는 어떤가요?
다음과 같이 제안해요. 메서드명도 바꿔 봤어요!
public boolean ownedBy(Member member) {
return getMember().equals(member);
}
public boolean isPrivate() {
return visibility.isPrivate();
}
public boolean isPublic() {
return visibility.isPublic();
}
jminkkk
reviewed
Oct 22, 2024
Comment on lines
74
to
76
| if (!template.matchMember(loginMember) && template.isPrivate()) { | ||
| throw new CodeZapException(ErrorCode.FORBIDDEN_ACCESS, "해당 템플릿은 비공개 템플릿입니다."); | ||
| } |
zangsu
reviewed
Oct 22, 2024
backend/src/main/java/codezap/template/controller/SpringDocTemplateController.java
Show resolved
Hide resolved
HoeSeong123
reviewed
Oct 22, 2024
Comment on lines
78
to
80
| public boolean matchMember(Member member) { | ||
| return getMember().equals(member); | ||
| } |
There was a problem hiding this comment.
일부러 getMember 사용하신건가요?
Suggested change
| public boolean matchMember(Member member) { | |
| return getMember().equals(member); | |
| } | |
| public boolean matchMember(Member member) { | |
| return this.member.equals(member); | |
| } |
zeus6768
previously approved these changes
Oct 23, 2024
zangsu
approved these changes
Oct 23, 2024
HoeSeong123
approved these changes
Oct 23, 2024
jminkkk
approved these changes
Oct 23, 2024
zeus6768
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
#739
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
10/23 10:00
해당 PR은 내일 릴리즈 전에 올라가야할 것 같습니다~ 빠른 리뷰 부탁드려요 !