좋아요 컬럼 반정규화 #893
Open
좋아요 컬럼 반정규화 #893
+94
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jminkkk
commented
Nov 4, 2024
Comment on lines
50
to
52
| if (FALSE.equals(isLiked(member, template))) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
기존에는 실제 있는지 확인하지 않고 바로 삭제를 했었는데요~
count--; 를 엔티티 내부에서 해주게 되면서, 확인하는 로직이 없으면 문제가 발생합니다. (내가 좋아요 하지 않은 것도 count-- 되버림)
따라서 검증 추가했어요~!
HoeSeong123
reviewed
Nov 5, 2024
| @@ -25,11 +28,12 @@ public class LikesService { | |||
| @Transactional | |||
| public void like(Member member, long templateId) { | |||
| Template template = templateRepository.fetchById(templateId); | |||
| if (isLiked(member, template)) { | |||
| if (TRUE.equals(isLiked(member, template))) { | |||
There was a problem hiding this comment.
소나린트가 경고를 띄우더라구요 ㅠㅅㅠ
There was a problem hiding this comment.
그런데 public Boolean isLiked(Member member, Template template) { // 이 메서드가 래퍼타입 반환하게 되어 있어서네요.
isLiked 메서드가 변경되어야 할 것 같네요
| @DisplayName("성공: 여러번 좋아요를 취소해도 정상 동작으로 판단") | ||
| void multipleLikes() { | ||
| @DisplayName("성공: 본인의 좋아요만 취소 가능") | ||
| void multipleCancelLikes() { |
There was a problem hiding this comment.
multiple도 같이 바꿔줘야 할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #741
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
11/06 13:00