fix: Transactional 추가 및 StepResponse 로직 수정

woowacourse-teams · Jul 25, 2024 · 9eff30a · 9eff30a
1 parent 123a23e
commit 9eff30a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/server/src/main/java/server/haengdong/application/EventService.java b/server/src/main/java/server/haengdong/application/EventService.java
@@ -5,6 +5,7 @@
 import java.util.List;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 import server.haengdong.application.request.EventAppRequest;
 import server.haengdong.application.response.ActionAppResponse;
 import server.haengdong.application.response.EventAppResponse;
@@ -20,6 +21,7 @@
 import server.haengdong.exception.HaengdongException;
 
 @RequiredArgsConstructor
+@Transactional(readOnly = true)
 @Service
 public class EventService {
 
@@ -28,6 +30,7 @@ public class EventService {
     private final BillActionRepository billActionRepository;
     private final MemberActionRepository memberActionRepository;
 
+    @Transactional
     public EventAppResponse saveEvent(EventAppRequest request) {
         String token = eventTokenProvider.createToken();
         Event event = request.toEvent(token);

diff --git a/server/src/main/java/server/haengdong/presentation/response/StepResponse.java b/server/src/main/java/server/haengdong/presentation/response/StepResponse.java
@@ -37,8 +37,6 @@ public static StepResponse of(List<ActionAppResponse> actions) {
             }
             if (currentActionType.equals("BILL")) {
                 actionsResponse.add(ActionsResponse.of(group, members));
-            } else {
-                actionsResponse.add(ActionsResponse.of(group, Set.of()));
             }
             currentActionType = typeName;
             group.clear();
@@ -53,8 +51,6 @@ public static StepResponse of(List<ActionAppResponse> actions) {
 
         if (currentActionType.equals("BILL")) {
             actionsResponse.add(ActionsResponse.of(group, members));
-        } else {
-            actionsResponse.add(ActionsResponse.of(group, null));
         }
 
         return new StepResponse(actionsResponse);