Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 멤버 추가 시 제대로 작동하지 않는 문제 수정 #653

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Sep 26, 2024

issue

구현 목적

#619
#631
에서 구현한 문제가 해결되지 않았습니다.

멤버를 추가할 경우, 인풋에 focus가 해제되는 경우도 있고,
전에 입력한 부분이 함께 입력되는 오류도 있습니다.

구현 사항

enter를 입력해도, isComposing이 true인 경우가 모바일에서 존재했습니다.
각 입력 상태를 검증하는 순서를 변경하고,
blur 후 focus를 줌으로써 isComposing을 초기화하는 방향을 선택했습니다.

🫡 참고사항

@Todari Todari added 🖥️ FE Frontend 🚨 bug bug 🔍 QC quality check labels Sep 26, 2024
@Todari Todari added this to the v2.0.0 milestone Sep 26, 2024
@Todari Todari self-assigned this Sep 26, 2024
@Todari Todari linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~!~ input이 너무 괴롭히네요ㅜㅜ

}
}
console.log(event.nativeEvent.isComposing);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log 지워주세요~

Copy link

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 굳굳쓰입니댜

@soi-ha soi-ha merged commit df06410 into fe-dev Sep 26, 2024
2 checks passed
@soi-ha soi-ha deleted the feature/#650 branch September 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 bug bug 🖥️ FE Frontend 🔍 QC quality check
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] 멤버 추가 시 제대로 작동하지 않는 문제 수정
4 participants