-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 랜딩페이지 스크롤 오류 해결 #797
Merged
Merged
[FE] 랜딩페이지 스크롤 오류 해결 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
jinhokim98
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많았습니다. 토다리
삼성 인터넷은 버그가 있지만 우리가 타겟으로 한 브라우저 환경이 아니기 때문에 넘어가도 될 것 같아요
soi-ha
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진짜 큰 이유였는데 뚝딱 해결해줘서 고마워요!
Merged
Todari
added a commit
that referenced
this pull request
Oct 24, 2024
* fix: Avatar component가 webp 이미지를 사용하도록 변경 * refactor: scroll 애니메이션의 작동 방식 변경 * style: lint 적용 및 useMainPageYScroll.ts 코드 구조 변경 * fix: 가로 스크롤이 되던 문제 해결 * feat: requestAnimationFrame을 이용해 애니메이션 최적화 진행 * style: 사용하지 않는 코드 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 목적
구현 사항
현재 가로 스크롤이 작동하는 과정은 아래와 같습니다.
이 과정에서, 종방향 스크롤을 강제로 못하게 원 위치로 되돌리는 방식이다 보니, 스크롤이 계속 유지되는 모바일 환경의 touch 이벤트에서는 제대로 작동하지 않는 것이 문제가 되었습니다.
또한, 스크롤 자체를 다시 원위치로 되돌이는 것이다 보니, 중간 중간 스크롤이 꿀렁거리는 오류가 있었습니다.
이를 해결하기 위해 작동 방식을 아래와 같이 변경하였습니다.
따라서, 스크롤은 실제로 이루어지고, default Event를 강제로 조작하지 않으므로 많은 환경에서 동일하게 작동할 것으로 기대됩니다.