Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useMoimInfoInput훅 테스트, MoimInfoInput validate함수 테스트 작성 #102

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

jaeml06
Copy link
Contributor

@jaeml06 jaeml06 commented Jul 24, 2024

PR의 목적이 무엇인가요?

테스트 환경 구축과 useMoimInfoInput훅 테스트, MoimInfoInput validate함수 테스트

이슈 ID는 무엇인가요?

설명

image

@jaeml06 jaeml06 added FE 프론트엔드 관련 이슈입니다. 👀 테스트 test (테스트를 작성하거나 수정) labels Jul 24, 2024
Copy link
Contributor

@ss0526100 ss0526100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴니당~

import useMoimInfoInput from './MoimCreatePage.hook';

jest.mock('./MoimCreatePage.util', () => ({
validateAuthorNickname: jest.fn(() => true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 무조건 true를 반환하는데 왜 handleChange를 해야하나요?

@@ -12,7 +12,7 @@ const POLICES = {
maximumAuthorNicknameLength: 10,

yyyymmddDashRegex: /^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12]\d|3[01])$/,
hhmmRegex: /^\d{2}:\d{2}$/,
hhmmRegex: /^([01]\d|2[0-3]):([0-5]\d)$/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaeml06 jaeml06 merged commit af3973f into develop-frontend Jul 25, 2024
1 check passed
@jaeml06 jaeml06 deleted the test/#101 branch July 25, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 관련 이슈입니다. 👀 테스트 test (테스트를 작성하거나 수정)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants