로그인 페이지 정적 UI 구현 #143
Merged
로그인 페이지 정적 UI 구현 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeml06
approved these changes
Jul 30, 2024
| export const formContainerStyle = css` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 20px; |
There was a problem hiding this comment.
개인적으로는 아직 gap의 단위를 rem으로 해야할지 px로 해야할지 고민이 되네요. 수야의 의견은 어떤가요?
There was a problem hiding this comment.
저 같은 경우는 글이 있는 경우 rem에 따라 간격이 늘어나는 것이 좋아보이기도하고, 그럴 필요까지 없는 것 같기도 하네요
ss0526100
approved these changes
Jul 31, 2024
| export const formContainerStyle = css` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 20px; |
| return <div css={S.layoutStyle}>{children}</div>; | ||
| } | ||
|
|
||
| LoginLayout.Header = LoginHeader; |
There was a problem hiding this comment.
TriSectionHeader로 통합해도 괜찮을 것 같아용~
ss0526100
reviewed
Jul 31, 2024
| @@ -22,6 +23,10 @@ const router = createBrowserRouter([ | |||
| path: ROUTES.participationComplete, | |||
| element: <ParticipationCompletePage />, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
이걸보니 토큰이 없을 때 다른 곳에 마음대로 접근하는 경우 로그인페이지로 강제 다이렉션 되어야 할 것 같다는 생각이 들어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
로그인 페이지의 정적 UI 기능 구현
이슈 ID는 무엇인가요?
설명
결과물 UI
디자인 시안이 러프하게 작성되어있기 때문에, 일단은 스타일링은 크게 신경쓰지 않았고, 기본 구조를 만드는 것에 집중했어요. 아래 내용은 구현 과정의 사고를 작성해봤어요. 코드 리뷰에 도움이 되길 바랍니다 😄
질문 혹은 공유 사항 (Optional)