Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

코멘트 section 구현 #170

Merged
merged 11 commits into from
Aug 1, 2024
Merged

코멘트 section 구현 #170

merged 11 commits into from
Aug 1, 2024

Conversation

jaeml06
Copy link
Contributor

@jaeml06 jaeml06 commented Aug 1, 2024

PR의 목적이 무엇인가요?

코멘트를 작성할 수 있는 section을 구현했습니다.

이슈 ID는 무엇인가요?

설명

CommentCard
image

CommentList
image

MessageInput 컴포넌트
image

현재 추가적인 사항으로 저 같은 경우 코멘트에 대한 시간을 백앤드에서 포맷팅해서 시간과 날짜를 합쳐서 보내준다고 했습니다. 현재는 dateTime으로 사용하고 있으니 참고해주세요

질문 혹은 공유 사항 (Optional)

@jaeml06 jaeml06 added FE 프론트엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현) labels Aug 1, 2024
Copy link
Contributor

@ss0526100 ss0526100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 구현하느라 고생하셨습니다~

어프루브 드릴께요~~!

display: flex;
align-items: center;
width: 100%;
background-color: #f3f4f6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme을 사용하지 않은 이유가 있으신가요?!(색이 colorPalete 안에 없다던가...)

height: 3rem;
`;

export const commnetBox = () => css`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수로 구현하신 이유가 있으실까요??

<div css={S.commentWrapper()}>
<ProfileFrame width={3} height={3} src={comment.src}></ProfileFrame>
<div css={S.commnetBox()}>
<div css={S.commnetHeader}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수형 스타일인데 호출을 안해도 작동이 되네요 신기방기똥방기

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇? 그렇다면 모든 스타일을 함수로 만들어도 문제없겠네요ㅋㅋ 바꾸기 귀찮았는데

Copy link
Contributor

@cys4585 cys4585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~

<div css={S.commentWrapper()}>
<ProfileFrame width={3} height={3} src={comment.src}></ProfileFrame>
<div css={S.commnetBox()}>
<div css={S.commnetHeader}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇? 그렇다면 모든 스타일을 함수로 만들어도 문제없겠네요ㅋㅋ 바꾸기 귀찮았는데

@jaeml06 jaeml06 merged commit c3e95d2 into develop-frontend Aug 1, 2024
1 check passed
@jaeml06 jaeml06 deleted the feat/#155 branch August 1, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants