-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
모임 상세 조회 기능 구현 #60
모임 상세 조회 기능 구현 #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영 부탁해요 ~
@ApiResponse(responseCode = "200", description = "모임 상세 조회 성공!"), | ||
}) | ||
@GetMapping("/{id}") | ||
public ResponseEntity<RestResponse<MoimDetailsFindResponse>> findMoimDetails(@PathVariable long id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id가 moimId가 아니라 id가 맞나요??
@Transactional(readOnly = true) | ||
public MoimDetailsFindResponse findMoimDetails(long id) { | ||
Moim moim = moimRepository.findById(id) | ||
.orElseThrow(IllegalArgumentException::new); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
예외 메시지는 어떻게 할까여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생헀어요 호귀~
PR의 목적이 무엇인가요?
모임 상세 조회기능을 구현합니다.
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)