Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

모임 상세 조회 기능 구현 #60

Merged
merged 5 commits into from
Jul 17, 2024
Merged

모임 상세 조회 기능 구현 #60

merged 5 commits into from
Jul 17, 2024

Conversation

hoyeonyy
Copy link
Contributor

PR의 목적이 무엇인가요?

모임 상세 조회기능을 구현합니다.

이슈 ID는 무엇인가요?

설명

  • 모임 상세 조회 기능 구현
  • 기존 모임 엔티티에서 현재 인원 수 추가

질문 혹은 공유 사항 (Optional)

@hoyeonyy hoyeonyy added BE 백엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현) labels Jul 17, 2024
@hoyeonyy hoyeonyy self-assigned this Jul 17, 2024
Copy link
Contributor

@ksk0605 ksk0605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mingyum-Kim Mingyum-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 부탁해요 ~

@ApiResponse(responseCode = "200", description = "모임 상세 조회 성공!"),
})
@GetMapping("/{id}")
public ResponseEntity<RestResponse<MoimDetailsFindResponse>> findMoimDetails(@PathVariable long id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id가 moimId가 아니라 id가 맞나요??

@Transactional(readOnly = true)
public MoimDetailsFindResponse findMoimDetails(long id) {
Moim moim = moimRepository.findById(id)
.orElseThrow(IllegalArgumentException::new);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외 메시지는 어떻게 할까여

Copy link
Contributor

@Mingyum-Kim Mingyum-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생헀어요 호귀~

@hoyeonyy hoyeonyy merged commit 175812b into develop-backend Jul 17, 2024
1 check passed
@Mingyum-Kim Mingyum-Kim deleted the feature/#56 branch July 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants