env 설정, msw 설정 #84
Merged
env 설정, msw 설정 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss0526100
approved these changes
Jul 21, 2024
| }), | ||
| new webpack.DefinePlugin({ | ||
| 'process.env.BASE_URL': JSON.stringify(process.env.BASE_URL)}), |
There was a problem hiding this comment.
이런식으로 일일히 환경변수를 추가해주어야 하나요..?
cys4585
reviewed
Jul 22, 2024
There was a problem hiding this comment.
env 설정, msw 설정 고생 많으셨습니다~
기존 작업한 것들 병합 먼저 하는 게 어떨까 싶어서 일단 approve는 해두지 않았어요~
@ss0526100 @jaeml06
코드 리뷰 하면서 든 생각인데, 여러 작업이 서로 연관성이 있는 것이 아니라면, PR을 별도로 올리면 작업물을 리뷰하는 데 조금 더 용이할 것 같아요. 이따 병합할 때 이야기 해보면 좋을 것 같아요 😀
| @@ -6,6 +6,7 @@ | |||
| "scripts": { | |||
| "test": "test", | |||
| "start": "webpack serve --config webpack.dev.js", | |||
| "start-prod": "webpack serve --config webpack.prod.js", | |||
There was a problem hiding this comment.
production을 dev server로 확인하는 게 맞을까요?? 🧐
| <App /> | ||
| </React.StrictMode>, | ||
| ); | ||
| async function enableMocking() { |
There was a problem hiding this comment.
지금 설정 기준으로, ENV가 development 인 경우 항상 api가 모킹되는 걸까요?
개발 환경일 때 mocking 여부를 선택할 수 있는 플래그가 있으면 어떨까 싶어서 여쭤봅니다~
| hints: false, | ||
| maxEntrypointSize: 512000, | ||
| maxAssetSize: 512000 | ||
| }, |
| devServer: { | ||
| historyApiFallback: true, | ||
| open: true, | ||
| }, |
There was a problem hiding this comment.
개발 시 필요한 dev server가 production 빌드에 사용되는 게 어색한 감이 있는 것 같아요😅
cys4585
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
.env 설정과 브러우저환경에서 msw 설정했습니다.
이슈 ID는 무엇인가요?
설명