Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 백엔드 리드미 추가 #837

Merged
merged 7 commits into from
Oct 24, 2024
Merged

docs: 백엔드 리드미 추가 #837

merged 7 commits into from
Oct 24, 2024

Conversation

hyeon0208
Copy link
Contributor

@hyeon0208 hyeon0208 commented Oct 24, 2024

🚩 연관 이슈

close #836


📝 작업 내용

백엔드 리드미 추가

여기서 보면 편하게 보실 수 있습니다.


🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

패키지 구조가 너무 긴데 디렉토리 뎁스를 낮추는게 나을까요 ??

Copy link

github-actions bot commented Oct 24, 2024

Test Results

174 tests   174 ✅  6s ⏱️
 47 suites    0 💤
 47 files      0 ❌

Results for commit 7784727.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 24, 2024

📝 Test Coverage Report

Overall Project 81.22% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

@mzeong mzeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디렉터리는 지금도 괜찮은데 가능하면 토글로 넣어도 좋을 것 같네요!


## **Contributors** 🙋🏻‍

|BE 카키|BE 조조|BE 콜리|BE 제리|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[제안] 닉네임(본명) 형태로 작성하는 것은 어떤가요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AN과 컨벤션 맞춰주면 좋겠어요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨벤션 통일해 반영 완료 ~!

Copy link
Contributor

@eun-byeol eun-byeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정리 감사합니다👍

Copy link
Contributor

@eun-byeol eun-byeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

패키지 구조 뎁스는 괜찮아요!
번거로운 작업이었을텐데 고생해주어 고마워요🙇‍♀️


<br>

## **아키텍처 구조** 🏗️
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[필수] ERD 추가 부탁드립니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어디갔지 ??
반영 완료 ~!


<br>

## **기술 스택** ⚙️
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지와 더불어서 저희 기술스택 선택 이유가 적혀져 있는 notion page가 토글로 함께 첨부되어도 좋을 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

링크가 한줄이라서 인용구로 추가했습니다 !


## **기술 스택** ⚙️

<img src="https://github.com/user-attachments/assets/1dfc2d88-b059-4d69-b38f-d7679d39befc" width="800" height="500">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지가 눌려서 한쪽은 auto로 두면 좋을것같아요!

Suggested change
<img src="https://github.com/user-attachments/assets/1dfc2d88-b059-4d69-b38f-d7679d39befc" width="800" height="500">
<img src="https://github.com/user-attachments/assets/1dfc2d88-b059-4d69-b38f-d7679d39befc" width="800" height="auto">

@hyeon0208 hyeon0208 merged commit cc62048 into develop Oct 24, 2024
4 checks passed
@hyeon0208 hyeon0208 deleted the feature/836 branch October 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: 백엔드 리드미 작성
4 participants