Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 약속을 나간 경우에도 eta 폴링 요청을 계속 보내는 버그 수정 #882

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kimhm0728
Copy link
Contributor

@kimhm0728 kimhm0728 commented Nov 4, 2024

🚩 연관 이슈

close #881


📝 작업 내용


🏞️ 스크린샷 (선택)

Screen_Recording_20241104_234251.mp4

약속 나간 경우 foreground service 알림이 없어지는지 확인하는 영상입니다


🗣️ 리뷰 요구사항 (선택)

reservation 엔티티는 삭제하는 코드는 작성했었는데
service stop하는 코드를 놓쳤네요..!!!

Copy link
Contributor

@aprilgom aprilgom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 버그가 있었군요
수고하셨습니다 올리브~~

Copy link
Contributor

@haeum808 haeum808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@kimhm0728 kimhm0728 merged commit a9932a2 into develop Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 약속을 나간 경우에도 eta 폴링 요청을 계속 보내는 버그 수정
3 participants