Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE-FEAT] 아이템 도감 API get 구현 #366

Open
wants to merge 8 commits into
base: be/develop
Choose a base branch
from

Conversation

dwax1324
Copy link

@dwax1324 dwax1324 commented Oct 14, 2024

🍄 PR 확인 사항

PR이 다음 요구 사항을 충족하는지 확인하세요. :

  • API 명세서가 업데이트 혹은 작성이 되어 있나요?

현재 작업은 어떤 이슈를 해결한 것인지 설명해주세요.

Issue Number: #365

  • 전체 아이템 리스트 반환 api
  • 단일 아이템 정보 반환 api

기존 코드에서 변경된 점이 있다면 설명해주세요. (추가 X)

데이터가 완전하진 않은데 일단 PR 올립니다!

@dwax1324 dwax1324 self-assigned this Oct 14, 2024
@dwax1324 dwax1324 added the BE_FEAT ✨ 백엔드 새로운 기능 label Oct 14, 2024
Copy link
Contributor

@jinchiim jinchiim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바쁘셨을텐데 고생 많으셨습니다! 😋
제 눈에는 딱히 리뷰 남길 사항이 없어보여 Approve 드립니다! 👍🏻

Copy link

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요!

구현 수고하셨습니다!

Copy link
Contributor

@jongmee jongmee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~! 넘 깔끔합니다 근데 CI 실패하는 것은 .. 왜죠?! 🫨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE_FEAT ✨ 백엔드 새로운 기능
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants