[Feature] - 랜딩 페이지 구현 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit ae1dde5. ♻️ This comment has been updated with latest results. |
jinyoung234
approved these changes
Oct 21, 2024
| (entries) => { | ||
| const updates: { [key: string]: AnimationState } = {}; | ||
| entries.forEach((entry) => { | ||
| console.log("entry", entry); |
깨지던 부분 수정했습니다! |
simorimi
approved these changes
Oct 21, 2024
| @@ -1 +1,7 @@ | |||
| export { default as ExcitedTturi } from "./excitedTturi.webp"; | |||
| export { default as BigTturi } from "./bigTturi.webp"; | |||
| ${({ theme, $textType = "body" }) => theme.typography.mobile[$textType]} | ||
| ${({ $isInline }) => ($isInline === true ? "display: inline" : "")} |
There was a problem hiding this comment.
inline 여부에 따라 inline 과 block 식으로 해도 괜찮을 거 같은데 이 부분은 참고만 해요!
| </div> | ||
| </S.Container> | ||
| <S.Gradient /> | ||
| <S.Image src={BigTturi} alt="" /> |
| @@ -1,6 +1,7 @@ | |||
| export const ROUTE_PATHS_MAP = { | |||
| back: -1, | |||
| root: "/", | |||
| main: "main", | |||
There was a problem hiding this comment.
해당 부분 메인으로 옮김에 따라 홈버튼 부분의 경우 main으로 라우팅 수정해야할 거 같다는 생각이 듭니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
2024-10-19.4.38.40.mp4
🙈 참고 사항