[톰캣 구현하기 - 1,2단계] 헙크(정현승) 미션 제출합니다. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGuga
reviewed
Sep 4, 2023
Comment on lines
18
to
22
| return new Response( | ||
| StatusLine.of(httpStatus), | ||
| ResponseHeader.of(responseBody), | ||
| responseBody | ||
| ); |
There was a problem hiding this comment.
여기서 Response 를 만들기 위해 HttpStatusCode 와 ResponseBody 를 받는데 HttpResponse 생성에 대한 전적인 책임을 지기 위해서는 HttpHeaders 도 같이 받는 것이 어떤가 의견내봅니다 ㅎㅎ
tomcat/src/main/java/org/apache/coyote/http11/response/StaticResource.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/Http11Processor.java
Outdated
Show resolved
Hide resolved
tomcat/src/main/java/org/apache/coyote/http11/Http11Processor.java
Outdated
Show resolved
Hide resolved
BGuga
requested changes
Sep 4, 2023
|
리뷰주셔서 감사합니다 푸우! 빠르게 넘어가려고만 했던 부분들에 대해서 푸우 덕분에 되돌아볼 수 있었던 것 같아요 ㅎㅎㅎ 여러 방어 로직이나, 엣지 케이스에 대해서 생각해볼 수 있었습니다. 빠르게 리뷰주셔서 정말 감사하고 또 얘기나눠봤으면 좋겠네요 ㅎㅎㅎ |
BGuga
requested changes
Sep 4, 2023
tomcat/src/main/java/org/apache/coyote/http11/request/Request.java
Outdated
Show resolved
Hide resolved
BGuga
requested changes
Sep 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
푸우 오랜만입니다 ㅎㅎㅎ 조금 급하게 구현하느라 저도 모르게 놓친게 많을 것 같습니다ㅠㅠ 너그러이 봐주세요 ㅎㅎㅎㅎ
Http11Processor를 최대한 가볍게 두고, 객체지향적으로 짜려고 노력했습니다! 미리 고마워요 푸우 :)