Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[톰캣 구현하기 3, 4단계] 썬샷(오진택) 미션 제출합니다. #479
[톰캣 구현하기 3, 4단계] 썬샷(오진택) 미션 제출합니다. #479
Changes from 7 commits
2ceb3b4
97b8a82
730c324
8859566
c70952c
24e135e
62644dd
ec51e20
6114aa7
e5e8416
628ccf8
b7d7d29
0bb3470
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
미션에서 준
AbstractController
는 Java EE의 HttpServlet을 투영한 것 같아요.따라서 이번 미션에서는
doPost
,doGet
등도 추가한 구조로 구현해보면 어떨까 싶습니다!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doPost()와 doGet()을 사용하는 방식으로 바꾸어주었습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헤더 값을 각 컨트롤러에서 하드코딩해주고 있는데 휴먼 에러의 위험이 있지 않을까요??!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Http Header도 메서드나 상태 코드와 같이 enum으로 관리해주도록 변경해주었습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비즈니스적인 커스텀 헤더를 추가하려고 하면 ENUM 타입의 KEY를 사용할 때 문제가 생길 수 있을 것 같아요.
Enum 제공 측은 톰캣 같은 범용적인 모듈이기 때문에 개발자가 그 Enum에 추가할 수도 없구요!
이러한 경우는 어떻게 하는 것이 좋을까요??!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분도 휴먼 에러를 줄이고, 분기를 줄이는 식으로 리팩토링할 수 있을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드 분리하고 상수화 좀 해주긴 했는데 만족스럽게 된 것 같진 않네요