[JDBC 라이브러리 구현하기 - 1단계] 하마드(이건회) 미션 제출합니다. #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackFoxx
approved these changes
Sep 28, 2023
| rs.getString("account"), | ||
| rs.getString("password"), | ||
| rs.getString("email") | ||
| ))); | ||
| } |
There was a problem hiding this comment.
실제 jdbcTemplate의 API 생김새를 그대로 재현했군요
멋있다진짜
| log.debug("query : {}", sql); | ||
| for (int i = 1; i < arguments.length + 1; i++) { | ||
| pstmt.setObject(i, arguments[i - 1]); | ||
| } |
There was a problem hiding this comment.
arguments를 배열로 바꾸어 향상된 for문을 쓸 수도 있었을 텐데 이 for문을 사용합 이유가 있읍니까?
| } | ||
|
|
||
|
|
||
| public User findById(final Long id) { | ||
| final var sql = "select id, account, password, email from users where id = ?"; |
There was a problem hiding this comment.
이번에 리플렉션을 많이 체화하셨으니
시간이 나신다면 이참에 namedParameter를 직접 만들어보는 것도 재미있을 것입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
여우(Fox) 안녕하세요. 하마드입니다.
JDBC 라이브러리 구현하기 1단계를 "진행시켜" 봤습니다.
매서운 리뷰 부탁드립니다ㅎㅎ
충돌 해결하는 커밋이 쌓여서, 제 코드 변경 사항은
여기
서 보면 될 것 같아요