[JDBC 라이브러리 구현하기 - 1단계] 로지(윤가영) 미션 제출합니다. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjooon2
requested changes
Sep 27, 2023
Comment on lines
57
to
64
| List<T> query = query(sql, rowMapper, params); | ||
| if (query.size() > 1) { | ||
| throw new RuntimeException("too many result"); | ||
| } | ||
| if (query.isEmpty()) { | ||
| return null; | ||
| } | ||
| return query.get(0); |
Comment on lines
81
to
85
| final List<T> results = new ArrayList<>(); | ||
| if (rs.next()) { | ||
| results.add(rowMapper.mapRow(rs, 0)); | ||
| } | ||
| return results; |
There was a problem hiding this comment.
resultSet 내의 row가 여러개일 때는 어떻게 되나요?🤔
iamjooon2
approved these changes
Sep 30, 2023
Comment on lines
+25
to
+26
| try (final Connection conn = dataSource.getConnection(); | ||
| final PreparedStatement pstmt = conn.prepareStatement(sql)) { |
There was a problem hiding this comment.
try-with-resource 도 적용해주셨군요!👍
| throw new RuntimeException("too many result"); | ||
| List<T> results = query(sql, rowMapper, params); | ||
| if (results.size() > 1) { | ||
| throw new RuntimeException("too many result. expected 1 but was " + results.size()); |
| } | ||
| return query.get(0); | ||
| return results.get(0); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.