Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDBC 라이브러리 구현하기 - 1단계] 후추(주찬민) 미션 제출합니다. #313

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

Combi153
Copy link

@Combi153 Combi153 commented Sep 28, 2023

안녕하세요 주노!

리뷰이로 만나뵙게 되어 영광입니다 😀

커밋 범위 입니다 잘 부탁드립니다~

@Combi153 Combi153 self-assigned this Sep 28, 2023
Copy link
Member

@Choi-JJunho Choi-JJunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 후추! 🧂
즐거운 한가위 잘 보내고계신가요~?

전체적으로 깔끔하게 미션을 잘 수행해주셨네요 👏👏
몇가지 궁금한 내용과 후추의 의견이 듣고싶은 부분이 있어 Request changes를 남겨봅니다!

수정 내용
- query 사용하도록 변경
- queryForObject 관련 테스트 수정
- size 검증 추가
Copy link
Member

@Choi-JJunho Choi-JJunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

후추~ 리뷰가 많이 늦어져서 죄송해요 ㅠㅠ
집에 갑자기 출몰한 바 선생님🪳을 퇴치하느라 정신없는 하루였네요 😇

1단계에서 반영해주신 내용 잘 확인했습니다 👏👏
2단계에서 뵙겠습니다!

@Choi-JJunho Choi-JJunho merged commit d8eff81 into woowacourse:combi153 Oct 3, 2023
1 check failed
@kpeel5839
Copy link

주노짱 너무 무서웠겠는데요 ? ㅋㅋㅋㅋ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants