[JDBC 라이브러리 구현하기 - 1단계] 디투(박정훈) 미션 제출합니다. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong-sile
requested changes
Oct 2, 2023
There was a problem hiding this comment.
전체적으로 코드가 엄청깔끔하네요.
잘 구현해주신 것 같습니다. 테스트 코드에서의 486은 흠칫했네요.
몇몇부분에 대해서 질문 남겼으니 답해주시면 감사하겠습니다.
추가적으로 별도의 jdbcTemplateTest를 작성해주시진 않으셨더라고요.
혹시 JdbcTemplateTest 코드를 작성하지 않으신 이유가 있나요?
만약에 이런 JdbcTemplate같은 새로운 라이브러리를 만들 때 테스트코드가 굉장히 중요할 것 같은데, 어떤 방식으로 테스트를 짤 수 있을까요?
질문에 대한 답을 듣고 싶어서, request changes해요.
코드적으론 흠잡을데가 없네요.
|
JDBC 템플릿 테스트를 하기 위해서 DataSource를 받아와야하는데, 그럴려면 H2를 의존성에 추가해야하더라구요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
반갑습니다 홍실. 명절 잘 보내고 계신가요? 캠퍼스에 나온다고 하셨는데 나오질 않으시네요. 내일은 나오실거죠?
한번쯤 리뷰이-리뷰어로 만나보고 싶었는데 함께 하게 되어서 기쁘네요.
그럼 화이팅입니다.
선물